dburr/eden
1
0
Fork 0
mirror of https://git.eden-emu.dev/eden-emu/eden.git synced 2025-07-23 02:45:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

file-sys: Default heavy-weight class destructors in the cpp file

Browse source 
Several classes have a lot of non-trivial members within them, or don't
but likely should have the destructor defaulted in the cpp file for
future-proofing/being more friendly to forward declarations.

Leaving the destructor unspecified allows the compiler to inline the
destruction code all over the place, which is generally undesirable from
a code bloat perspective.
This commit is contained in:
Lioncash 2018-09-19 19:19:05 -04:00
parent 0432af5ad1
commit 05ef9dfc10
25 changed files with 45 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/core/file_sys/control_metadata.cpp
View file

@ -20,6 +20,8 @@ NACP::NACP(VirtualFile file) : raw(std::make_unique<RawNACP>()) {
file->ReadObject(raw.get());
}
NACP::~NACP() = default;
const LanguageEntry& NACP::GetLanguageEntry(Language language) const {
if (language != Language::Default) {
return raw->language_entries.at(static_cast<u8>(language));