dburr/eden
1
0
Fork 0
mirror of https://git.eden-emu.dev/eden-emu/eden.git synced 2025-07-21 21:35:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

file-sys: Default heavy-weight class destructors in the cpp file

Browse source 
Several classes have a lot of non-trivial members within them, or don't
but likely should have the destructor defaulted in the cpp file for
future-proofing/being more friendly to forward declarations.

Leaving the destructor unspecified allows the compiler to inline the
destruction code all over the place, which is generally undesirable from
a code bloat perspective.
This commit is contained in:
Lioncash 2018-09-19 19:19:05 -04:00
parent bd66646f8b
commit 315f6ef402
25 changed files with 45 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/core/file_sys/program_metadata.cpp
View file

@ -12,6 +12,10 @@
namespace FileSys {
ProgramMetadata::ProgramMetadata() = default;
ProgramMetadata::~ProgramMetadata() = default;
Loader::ResultStatus ProgramMetadata::Load(VirtualFile file) {
std::size_t total_size = static_cast<std::size_t>(file->GetSize());
if (total_size < sizeof(Header))