dburr/eden
1
0
Fork 0
mirror of https://git.eden-emu.dev/eden-emu/eden.git synced 2025-07-20 14:05:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

yuzu qt: Revert some usages of string_view

Browse source 
Causes a heap-use-after free reported by AddressSanitizer. This makes
use of std::filesystem::path, but due to that we have to use their
string() function which may not work for all characters.
This commit is contained in:
lat9nq 2021-06-02 15:05:45 -04:00
parent 255597ad04
commit 680de959a6
7 changed files with 27 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/yuzu/configuration/config.h
View file

@ -22,7 +22,7 @@ public:
InputProfile,
};
explicit Config(std::string_view config_name = "qt-config",
explicit Config(const std::string& config_name = "qt-config",
ConfigType config_type = ConfigType::GlobalConfig);
~Config();
@ -45,7 +45,7 @@ public:
static const std::array<UISettings::Shortcut, 17> default_hotkeys;
private:
void Initialize(std::string_view config_name);
void Initialize(const std::string& config_name);
void ReadValues();
void ReadPlayerValue(std::size_t player_index);