dburr/eden
1
0
Fork 0
mirror of https://git.eden-emu.dev/eden-emu/eden.git synced 2025-07-23 19:05:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

yuzu qt: Revert some usages of string_view

Browse source 
Causes a heap-use-after free reported by AddressSanitizer. This makes
use of std::filesystem::path, but due to that we have to use their
string() function which may not work for all characters.
This commit is contained in:
lat9nq 2021-06-02 15:05:45 -04:00
parent 255597ad04
commit 680de959a6
7 changed files with 27 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/yuzu/configuration/configure_per_game.h
View file

@ -28,7 +28,8 @@ class ConfigurePerGame : public QDialog {
Q_OBJECT
public:
explicit ConfigurePerGame(QWidget* parent, u64 title_id, std::string_view file_name);
// Cannot use std::filesystem::path due to https://bugreports.qt.io/browse/QTBUG-73263
explicit ConfigurePerGame(QWidget* parent, u64 title_id, const std::string& file_name);
~ConfigurePerGame() override;
/// Save all button configurations to settings file