From ba015f825f55d71d527c0eab8fea073266f3a5b0 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Thu, 19 Jul 2018 01:27:27 -0400 Subject: [PATCH] file_util: return string by const reference for GetExeDirectory() This disallows modifying the internal string buffer (which shouldn't be modified anyhow). --- src/common/file_util.cpp | 2 +- src/common/file_util.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/common/file_util.cpp b/src/common/file_util.cpp index bf955386ce..c882ab39f5 100644 --- a/src/common/file_util.cpp +++ b/src/common/file_util.cpp @@ -592,7 +592,7 @@ std::string GetBundleDirectory() { #endif #ifdef _WIN32 -std::string& GetExeDirectory() { +const std::string& GetExeDirectory() { static std::string exe_path; if (exe_path.empty()) { wchar_t wchar_exe_path[2048]; diff --git a/src/common/file_util.h b/src/common/file_util.h index 026c84d948..1f38b1560e 100644 --- a/src/common/file_util.h +++ b/src/common/file_util.h @@ -133,7 +133,7 @@ std::string GetBundleDirectory(); #endif #ifdef _WIN32 -std::string& GetExeDirectory(); +const std::string& GetExeDirectory(); std::string AppDataRoamingDirectory(); #endif