dburr/eden
1
0
Fork 0
mirror of https://git.eden-emu.dev/eden-emu/eden.git synced 2025-07-23 19:05:45 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
25601 commits 33 branches 3 tags 135 MiB
Commit graph

377 commits

Author SHA1 Message Date
Kelebek1
b659019c90 Support more PCM formats. Fixes Ys IX audio. 2021-07-06 18:43:23 +01:00
Morph
64f22684d4 CMakeLists: Treat -Wsign-compare as an error on GCC/Clang 
Treats (un)signed comparison mismatches as errors to be consistent with MSVC
 2021-07-06 12:50:09 -04:00
Kelebek1
07e637d8c6 Fix XC2/VOEZ crashing, add audio looping and a few misc fixes 2021-07-01 06:01:01 +01:00
lat9nq
794c444285 general: Make most settings a BasicSetting 
Creates a new BasicSettings class in common/settings, and forces setting
a default and label for each setting that uses it in common/settings.
Moves defaults and labels from both frontends into common settings.
Creates a helper function in each frontend to facillitate reading the
settings now with the new default and label properties.

Settings::Setting is also now a subclass of Settings::BasicSetting. Also
adds documentation for both Setting and BasicSetting.
 2021-06-28 17:32:17 -04:00
Kelebek1
b46191d104 Decouple audio processing and run at variable rate 
Currently, processing of audio samples is called from AudioRenderer's Update method, using a fixed 4 buffers to process the given samples. Games call Update at variable rates, depending on framerate and/or sample count, which causes inconsistency in audio processing. From what I've seen, 60 FPS games update every ~0.004s, but 30 FPS/160 sample games update somewhere between 0.02 and 0.04, 5-10x slower. Not enough samples get fed to the backend, leading to a lot of audio skipping.

This PR seeks to address this by de-coupling the audio consumption and the audio update. Update remains the same without calling for buffer queuing, and the consume now schedules itself to run based on the sample rate and count.
 2021-06-27 15:58:07 +01:00
bunnei
2c6a61d4dd audio_core: common: Bump audio revision to 9. 
- This is used in fw 12.x.x games.
 2021-06-24 18:22:10 -07:00
Chloe
a9a9167009 Add missing includes (#6521) 
* Add missing includes

* Add array
 2021-06-24 03:24:17 -04:00
Kelebek1
5015541902 Implement audout GetAudioOutPlayedSampleCount 
Used in Ninja Gaiden games.
 2021-06-22 04:39:17 +01:00
Clément Gallet
3af2ea232f Various suggestions by v1993 and lioncash 2021-06-07 12:51:59 +02:00
Clément Gallet
34848e5eda Add SDL2 audio backend 2021-06-06 11:28:38 +02:00
Morph
7ebc38a6d1 general: Replace RESULT_SUCCESS with ResultSuccess 
Transition to PascalCase for result names.
 2021-06-02 00:39:27 -04:00
bunnei
7a76bc30fa common: Move settings to common from core. 
- Removes a dependency on core and input_common from common.
 2021-04-14 16:24:03 -07:00
Chloe Marcec
6d5a42e4aa revert to std::sin and std::cos 2021-02-12 18:48:10 -08:00
Chloe Marcec
dccb1546a8 address issues 2021-02-12 18:48:10 -08:00
Chloe Marcec
dffe01cb67 audren: Implement I3dl2Reverb 
Most notable fix is the voices in Fire Emblem Three Houses
 2021-02-12 18:48:10 -08:00
bunnei
eaacb5047c Merge pull request #5868 from german77/HandheldFix 
Prevent over scheduling audio events and add motion update unschedule event
 2021-02-08 11:33:53 -08:00
german
e0c83e305a Prevent over scheduling audio events and terminate properly the motion update event 2021-02-02 10:17:10 -06:00
Chloe Marcec
6619834395 audren: Disable reverb for the time being 
As this is causing issues in a few games, it's best to have it disabled until it's completely implemented
 2021-02-01 14:41:58 +11:00
Chloe Marcec
b467478dcf audout: FlushAudioOutBuffers 
Fixes Devil May Cry
 2021-01-24 19:13:34 +11:00
ReinUsesLisp
4854f3291e core: Silence Wclass-memaccess warnings 
This requires making several types trivial and properly initialize
them whenever they are called.
 2021-01-15 16:31:19 -03:00
ReinUsesLisp
92ca4929f5 common/common_funcs: Rename INSERT_UNION_PADDING_{BYTES,WORDS} to _NOINIT 
INSERT_PADDING_BYTES_NOINIT is more descriptive of the underlying behavior.
 2021-01-15 16:27:28 -03:00
bunnei
34d62f16cc Merge pull request #5264 from 16-Bit-Dog/patch-1 
Make the coding conventions more consistant
 2020-12-31 01:46:53 -08:00
16-Bit-Dog
a96fd630b4 Make the coding conventions more consistant 
lut_index had 0 added when nothing was supposed to be added

despite this, index was not added to 0 when nothing was supposed to be added...
 2020-12-30 19:03:26 -05:00
bunnei
e5f216261e hle: service: Acquire and release a lock on requests. 
- This makes it such that we can safely access service members from CoreTiming thread.
 2020-12-28 21:33:34 -08:00
bunnei
93b4668017 audio_core: stream: Ensure buffer is valid before release. 2020-12-28 21:33:34 -08:00
Vitor Kiguchi
31a3bf1b8c Update cubeb and request a persistent stream session 2020-12-05 22:26:41 +01:00
bunnei
4547af2ba5 Merge pull request #5000 from lioncash/audio-error 
audio_core: Make shadowing and unused parameters errors
 2020-12-02 23:08:43 -08:00
Lioncash
29db886722 audio_core: Make shadowing and unused parameters errors 
Moves the audio code closer to enabling warnings as errors in general.
 2020-12-03 00:54:31 -05:00
Chloe Marcec
35f0c8e80e audio_core: Remove temp_mix_buffer 
It's unused and doesn't need to be initialized
 2020-11-28 23:25:28 +11:00
Chloe Marcec
808da92335 Addressed changes 2020-11-17 15:40:19 +11:00
Chloe Marcec
a894cf5169 audren: Make use of nodiscard, rework downmixing, release all buffers 
Preliminary work for upmixing & general cleanup. Fixes basic issues in games such as Shovel Knight and slightly improves the LEGO games. Upmixing stitll needs to be implemented.

Audio levels in a few games will be fixed as we now use the downmix coefficients when possible instead of supplying our own
 2020-11-17 14:14:29 +11:00
Lioncash
2d48020ca5 core: Fix clang build pt.2 
Resolves the clang build issue in a more unintrusive way.
 2020-10-20 22:16:03 -04:00
bunnei
deb3536936 Revert "core: Fix clang build" 2020-10-20 19:07:39 -07:00
Lioncash
18636013c9 core: Fix clang build 
Recent changes to the build system that made more warnings be flagged as
errors caused building via clang to break.

Fixes #4795
 2020-10-17 19:50:39 -04:00
Lioncash
8452ec7d7b audio_core/CMakeLists: Make warnings consistent with core 
Normalizes the warnings shared between audio_core and core.
 2020-10-13 16:36:58 -04:00
bunnei
e61d8de5f6 Merge pull request #4721 from lioncash/genfn 
codec: Make lookup table static constexpr
 2020-09-29 15:16:24 -07:00
bunnei
f5e1ea81bc Merge pull request #4722 from lioncash/casting 
cubeb_sink: Use static_cast instead of reinterpret_cast in DataCallback()
 2020-09-29 15:09:12 -07:00
bunnei
bab40bb134 Merge pull request #4719 from lioncash/audio-warn 
audio_core: Resolve sign conversion warnings
 2020-09-27 01:52:59 -07:00
bunnei
1af3773aef Merge pull request #4720 from lioncash/header 
audio_core: Remove unnecessary inclusions
 2020-09-25 22:04:26 -07:00
Lioncash
3e926b6481 command_generator: Make lookup table static constexpr 
Allows compilers to elide needing to push these values on the stack
every time the function is called.
 2020-09-25 18:33:04 -04:00
Lioncash
a97ec95061 behavior_info: Fix typo Renerer -> Renderer 2020-09-25 17:14:02 -04:00
Lioncash
1fc5fae82f cubeb_sink: Use static_cast instead of reinterpret_cast in DataCallback() 
Conversions from void* to the proper data type are well-defined and
supported by static_cast. We don't need to use reinterpret_cast here.
 2020-09-25 17:10:02 -04:00
Lioncash
f2c756b0f4 codec: Make lookup table static constexpr 
Allows compilers to elide needing to push these values on the stack
every time the function is called.
 2020-09-25 14:24:25 -04:00
Lioncash
c6fe328f73 audio_core: Remove unnecessary inclusions 
Same behavior, but removes header dependencies where they don't need to
be.
 2020-09-25 13:19:42 -04:00
Lioncash
8e2814d9ad audio_core: Resolve sign conversion warnings 
While were at it, we can also enable sign conversion warnings and other
common warnings as errors to prevent these from creeping back into the
codebase.
 2020-09-25 01:22:47 -04:00
Lioncash
165a083705 effect_context: Make use of explicit where applicable 
While we're at it we can make the destructor of the base class virtual
to ensure that any polymorphism issues never occur.
 2020-09-25 00:27:11 -04:00
Lioncash
6632af0301 audio_core/command_generator: Use const references where applicable 
In a lot of cases, we can make use of const references rather than
non-const references.

While we're in the area we can silence some truncation and sign
conversion warnings.
 2020-09-17 13:52:55 -04:00
Lioncash
d0b648ecf8 audio_core/command_generator: Avoid an unnecessary copy in GenerateFinalMixCommand() 2020-09-17 13:45:24 -04:00
bunnei
b205c01a95 Merge pull request #4310 from ogniK5377/apollo-1-prod 
audio_core: Apollo Part 1, AudioRenderer refactor
 2020-09-11 10:57:27 -04:00
David Marcec
f17f347e03 Preliminary effects 2020-08-17 01:23:55 +10:00