7160 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
bunnei	dbb4596293	Merge pull request #717 from lioncash/explicit ... hle/service: Make constructors explicit where applicable	2018-07-19 16:08:07 -07:00
bunnei	b4a4383fb5	Merge pull request #716 from lioncash/construct ... nvflinger: Emplace Display instances directly	2018-07-19 14:18:29 -07:00
bunnei	a5d3565cd8	Merge pull request #715 from lioncash/const-ref ... nvdrv: Take std::string by const reference in GetDevice()	2018-07-19 13:27:48 -07:00
Sebastian Valle	ee244af2f4	Merge pull request #720 from Subv/getentrytype_root ... Filesystem: Return EntryType::Directory for the root directory.	2018-07-19 15:23:32 -05:00
Sebastian Valle	9017666b6f	Merge pull request #714 from lioncash/index ... hle_ipc: Amend usage of buffer_index within one of HLERequestContext's WriteBuffer() overloads	2018-07-19 14:36:34 -05:00
bunnei	1f2644b474	Merge pull request #712 from lioncash/fsp ... fsp_srv: Misc individual changes	2018-07-19 12:31:33 -07:00
bunnei	153756ced5	Merge pull request #713 from lioncash/filesys ... filesystem: Minor changes	2018-07-19 11:49:06 -07:00
bunnei	9f6fe39602	Merge pull request #711 from lioncash/swap ... common/swap: Minor changes	2018-07-19 11:48:16 -07:00
bunnei	a8139e0c59	Merge pull request #710 from lioncash/unused ... common/common_funcs: Remove unused rotation functions	2018-07-19 11:43:41 -07:00
bunnei	fb8a2dd552	Merge pull request #694 from lioncash/warn ... loader/{nro, nso}: Resolve compilation warnings	2018-07-19 11:43:14 -07:00
Subv	c1b5369f60	Filesystem: Return EntryType::Directory for the root directory. ... It is unknown if this is correct behavior, but it makes sense and fixes a regression with Stardew Valley.	2018-07-19 13:11:09 -05:00
bunnei	b2d1d18681	Merge pull request #709 from lioncash/thread-local ... common/misc: Deduplicate code in GetLastErrorMsg()	2018-07-19 10:00:48 -07:00
bunnei	046c09a092	Merge pull request #708 from lioncash/xbyak ... externals: Update Xbyak to 5.65	2018-07-19 10:00:06 -07:00
bunnei	69ba9b666d	Merge pull request #707 from lioncash/catch ... externals: Update catch to v2.2.3	2018-07-19 09:59:44 -07:00
Lioncash	e664bf00ed	hle/service: Make constructors explicit where applicable ... Prevents implicit construction and makes these lingering non-explicit constructors consistent with the rest of the other classes in services.	2018-07-19 12:25:02 -04:00
Lioncash	f31b335a27	nvflinger: Emplace Display instances directly ... We can use emplace_back to construct the Display instances directly, instead of constructing them separately and copying them, avoiding the need to copy std::string and std::vector instances that are part of the Display struct.	2018-07-19 11:50:12 -04:00
bunnei	4b6bc818bf	Merge pull request #705 from lioncash/string-ref ... file_util: return string by const reference for GetExeDirectory()	2018-07-19 08:47:06 -07:00
bunnei	232392968f	Merge pull request #704 from lioncash/string ... string_util: Remove AsciiToHex()	2018-07-19 08:46:40 -07:00
bunnei	280f1100b6	Merge pull request #703 from lioncash/const ... savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function	2018-07-19 08:46:15 -07:00
bunnei	bdf9a9c044	Merge pull request #702 from lioncash/initialize ... partition_filesystem: Ensure all class members of PartitionFilesystem are initialized	2018-07-19 08:45:54 -07:00
bunnei	a0c32fc161	Merge pull request #701 from lioncash/moving ... content_archive: Minor changes	2018-07-19 08:41:42 -07:00
Lioncash	6b1043fab4	nvdrv: Take std::string by const reference in GetDevice() ... This is only ever used as a lookup into the device map, so we don't need to take the std::string instance by value here.	2018-07-19 11:40:36 -04:00
Lioncash	a52cb33af2	hle_ipc: Amend usage of buffer_index within one of HLERequestContext's WriteBuffer() overloads ... Previously, the buffer_index parameter was unused, causing all writes to use the buffer index of zero, which is not necessarily what is wanted all the time. Thankfully, all current usages don't use a buffer index other than zero, so this just prevents a bug before it has a chance to spring.	2018-07-19 11:10:16 -04:00
Lioncash	6fff93da5f	fsp_srv: Remove unnecessary vector construction in IFile's Write() function ... We can avoid constructing a std::vector here by simply passing a pointer to the original data and the size of the copy we wish to perform to the backend's Write() function instead, avoiding copying the data where it's otherwise not needed.	2018-07-19 11:01:07 -04:00
Lioncash	45e747beaa	fsp_srv: Remove unnecessary std::vector construction in IDirectory's Read() function ... We were using a second std::vector as a buffer to convert another std::vector's data into a byte sequence, however we can just use pointers to the original data and use them directly with WriteBuffer, which avoids copying the data at all into a separate std::vector. We simply cast the pointers to u8* (which is allowed by the standard, given std::uint8_t is an alias for unsigned char on platforms that we support).	2018-07-19 10:46:54 -04:00
bunnei	f15104730f	Merge pull request #699 from lioncash/vfs ... vfs: Deduplicate accumulation code in VfsDirectory's GetSize()	2018-07-19 07:38:45 -07:00
bunnei	ca8697b7d9	Merge pull request #697 from bunnei/disable-depth-cull ... gl_state: Temporarily disable culling and depth test.	2018-07-19 07:38:00 -07:00
Lioncash	043ab179b5	filesystem: std::move VirtualDir instance in VfsDirectoryServiceWrapper's constructor ... Avoids unnecessary atomic reference count incrementing and decrementing	2018-07-19 10:34:11 -04:00
Lioncash	7ab5eb948c	filesystem: Use std::string's empty() function instead of comparing against a literal ... This is simply a basic value check as opposed to potentially doing string based operations (unlikely, but still, avoiding it is free).	2018-07-19 10:32:23 -04:00
Lioncash	9dccecb6b0	filesystem: Remove pragma disabling global optimizations ... This was just an artifact missed during PR review.	2018-07-19 10:30:53 -04:00
Lioncash	b9758eeb2f	fsp_srv: Make IStorage constructor explicit ... Prevents implicit conversions.	2018-07-19 10:04:16 -04:00
Lioncash	c835e6f941	fsp_srv: Add missing includes ... Gets rid of relying on indirect inclusions.	2018-07-19 10:03:17 -04:00
Lioncash	b4efdeb80b	fsp_srv: Resolve sign-mismatch warnings in assertion comparisons	2018-07-19 09:58:32 -04:00
Lioncash	106207e2ca	fsp_srv: Respect write length in Write() ... Previously we were just copying the data whole-sale, even if the length was less than the total data size. This effectively makes the actual_data vector useless, which is likely not intended. Instead, amend this to only copy the given length amount of data. At the same time, we can avoid zeroing out the data before using it by passing iterators to the constructor instead of a size.	2018-07-19 09:57:48 -04:00
Lioncash	5edccd695c	common/swap: Remove unnecessary const on return value of swap()	2018-07-19 09:35:54 -04:00
Lioncash	f66d29acf2	common/swap: Use static_cast where applicable	2018-07-19 09:35:13 -04:00
Lioncash	d7ebfa40a1	common/swap: Use using aliases where applicable	2018-07-19 09:32:13 -04:00
Lioncash	3ec8aa2bb9	common/common_funcs: Remove unused rotation functions ... These are unused and essentially don't provide much benefit either. If we ever need rotation functions, these can be introduced in a way that they don't sit in a common_* header and require a bunch of ifdefing to simply be available	2018-07-19 09:21:23 -04:00
Lioncash	03d8c78199	common/misc: Deduplicate code in GetLastErrorMsg() ... Android and macOS have supported thread_local for quite a while, but most importantly is that we don't even really need it. Instead of using a thread-local buffer, we can just return a non-static buffer as a std::string, avoiding the need for that quality entirely.	2018-07-19 09:15:38 -04:00
Lioncash	1dbed8591f	externals: Update Xbyak to 5.65 ... Keeps the JIT assembler library up to date and ensures we don't run into any issues that may have been resolved.	2018-07-19 08:38:07 -04:00
Lioncash	c95cc86b63	externals: Update catch to v2.2.3 ... Keeps the unit-testing library up to date.	2018-07-19 08:33:06 -04:00
Lioncash	ba015f825f	file_util: return string by const reference for GetExeDirectory() ... This disallows modifying the internal string buffer (which shouldn't be modified anyhow).	2018-07-19 01:27:29 -04:00
bunnei	49881ebe2c	Merge pull request #700 from bunnei/update-dynarmic ... externals: Update dynarmic to 5a91c94.	2018-07-18 22:01:39 -07:00
Lioncash	7ad7ee1411	string_util: Remove AsciiToHex() ... Easy TODO	2018-07-18 23:57:15 -04:00
bunnei	25c34badfa	Merge pull request #692 from lioncash/assign ... address_arbiter: Correct assignment within an assertion statement in WakeThreads()	2018-07-18 20:56:28 -07:00
bunnei	90042f35a5	Merge pull request #690 from lioncash/move ... core/memory, core/hle/kernel: Use std::move where applicable	2018-07-18 20:55:55 -07:00
Lioncash	f92bb43138	savedata_factory: Make SaveDataDescriptor's DebugInfo() function a const member function ... This function doesn't alter class state.	2018-07-18 23:50:07 -04:00
Lioncash	a9b596c444	partition_filesystem: Ensure all class members of PartitionFilesystem are initialized ... Previously is_hfs and pfs_header members wouldn't be initialized in the constructor, as they were stored in locals instead. This would result in things like GetName() and PrintDebugInfo() behaving incorrectly. While we're at it, initialize the members to deterministic values as well, in case loading ever fails.	2018-07-18 23:45:22 -04:00
bunnei	9a4fa973c8	gl_state: Temporarily disable culling and depth test.	2018-07-18 23:21:43 -04:00
Lioncash	9eb43dc910	content_archive: Make IsDirectoryExeFS() take a shared_ptr as a const reference ... There's no need to take this by value when it's possible to avoid unnecessary copies entirely like this.	2018-07-18 23:19:28 -04:00